Skip to content

Unicode, String internals #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mahdiHash merged 9 commits into from
Jul 14, 2023
Merged

Unicode, String internals #269

mahdiHash merged 9 commits into from
Jul 14, 2023

Conversation

@mostafa-nematpour
Copy link
Contributor

@mostafa-nematpour mostafa-nematpour commented Jul 12, 2023

translate Unicode, String internals

@javascript-translate-bot javascript-translate-bot requested a review from a team July 12, 2023 21:09
@CLAassistant
Copy link

CLAassistant commented Jul 12, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Jul 12, 2023
Open
mahdyar
mahdyar requested changes Jul 12, 2023
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 12, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mostafa-nematpour
Copy link
Contributor Author

mostafa-nematpour commented Jul 12, 2023

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 12, 2023 21:58
mahdiHash
mahdiHash suggested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to a batch and create a commit just once (docs).

@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 13, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mostafa-nematpour
Copy link
Contributor Author

mostafa-nematpour commented Jul 13, 2023

Thanks for the suggestions Mehdi
I will try to be better and next time I will put all in one
I'm not good at it
/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 13, 2023 06:34
@mahdiHash
Copy link
Contributor

mahdiHash commented Jul 13, 2023

Thanks for the suggestions Mehdi I will try to be better and next time I will put all in one I'm not good at it /done

No worries, mate :)
Thanks for your contribution, @mostafa-nematpour.

@mahdiHash mahdiHash merged commit 3190e58 into javascript-tutorial:master Jul 14, 2023
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jul 14, 2023

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@mostafa-nematpour mostafa-nematpour deleted the unicode branch July 14, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar requested changes

+1 more reviewer

@mahdiHash mahdiHash mahdiHash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mostafa-nematpour @CLAassistant @javascript-translate-bot @mahdiHash @mahdyar