Error handling with promises #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines 154 and 169 need more attention.
mahdiHash
commented
Sep 8, 2022
mahdiHash
commented
Sep 8, 2022
mahdyar
approved these changes
Sep 9, 2022
Member
There was a problem hiding this comment.
"Unhandled" has to be translated since I've translated the word "handle" everywhere. The problem is with "rejection". In this article I didn't translate the words "reject" and "resolve". IMO they're better to be left as is, so, "rejection" can be "rejection". But I like to have your opinion on it, too.
P.S. I want to change the translation of some words in the vocabulary of README. This change will keep them in English (not translated).
I agree. LGTM!
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and comment/commit if anything is wrong.