Error handling, "try...catch" #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mahdyar merged 17 commits into javascript-tutorial:master from mahdiHash:master

Feb 6, 2022

Contributor

mahdiHash commented Feb 4, 2022

Please review and comment/commit if anything is wrong.

mahdiHash added 16 commits

January 27, 2022 13:13


          Translate a part of article

99393df


          Translate a part of article

c409c1f

Line 88 needs more attention


          Translate a part of article

90b66cc


          Translate a part of article

235295e

Line 164 needs more attention.


          Translate a part of article

c6b2757


          Translate a part of article


          Translate a part of article

1b5e84d

Line 286 needs more attention.


          Translate a part of article

b890723

Line 354 needs more attention.


          Translate a part of article

81c0b68

Line 496 needs more attention.


          Translate a part of article

8205bda


          Change محاسبه to اندازهگیری

edb39d2


          Replace a dot with a comma

c915cb5


          Translate a part of article

106cec8


          Translate a part of article

40dd781

Line 667 and 626 need more attention.


          Translate "finally-or-code-after" task and solution

1975b58


          Change the comma

026c81f

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

February 4, 2022 18:22

javascript-translate-bot mentioned this pull request

Persian (Farsi) Translation Progress #1

Open

mahdiHash commented

View reviewed changes

1-js/10-error-handling/1-try-catch/article.md Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/10-error-handling/1-try-catch/article.md Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/10-error-handling/1-try-catch/article.md Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/10-error-handling/1-try-catch/article.md Outdated Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/10-error-handling/1-try-catch/article.md Outdated Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/10-error-handling/1-try-catch/article.md Show resolved Hide resolved

mahdiHash commented

View reviewed changes

1-js/10-error-handling/1-try-catch/article.md Show resolved Hide resolved

mahdiHash marked this pull request as ready for review

February 4, 2022 18:26

mahdyar requested changes

View reviewed changes

Member

mahdyar left a comment

Please review the suggested change(s) and request another review.

javascript-translate-bot added changes requested and removed review needed labels

javascript-translate-bot commented Feb 5, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻


          Apply suggestions from code review

1449c45

Co-authored-by: Mahdyar Hasanpour <[email protected]>

Contributor Author

mahdiHash commented Feb 5, 2022

Thanks for your review, @mahdyar.
/done

javascript-translate-bot added review needed and removed changes requested labels

javascript-translate-bot requested a review from a team

February 5, 2022 19:04

javascript-translate-bot removed the review needed label

mahdyar approved these changes

View reviewed changes

javascript-translate-bot added the needs +1 label

Member

mahdyar commented Feb 6, 2022

Thank you, @mahdiHash!

mahdyar merged commit fd8848b into javascript-tutorial:master

javascript-translate-bot commented Feb 6, 2022

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels