Skip to content

DOM tree #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mahdyar merged 50 commits into from
Jan 14, 2022
Merged

DOM tree #188

mahdyar merged 50 commits into from
Jan 14, 2022

Conversation

@Beroozam
Copy link
Contributor

@Beroozam Beroozam commented Jan 7, 2022

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team January 7, 2022 19:26
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 7, 2022
Open
@mahdiHash
Copy link
Contributor

mahdiHash commented Jan 7, 2022 •
edited
Loading

Hi, @Beroozam.
Please open a pull request when the translation is ready.
Since the article and other files are not fully translated yet, I'll convert this PR to draft for now.
You can set it to "ready for review" whenever you're done translating.
Good luck!

@mahdiHash mahdiHash marked this pull request as draft January 7, 2022 20:40
@Beroozam Beroozam marked this pull request as ready for review January 12, 2022 19:25
@Beroozam
Copy link
Contributor Author

Beroozam commented Jan 12, 2022

Thank you in advance for your guidance

mahdiHash
mahdiHash suggested changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to batch and create a commit just once (docs).

Beroozam and others added 18 commits January 13, 2022 17:01
@Beroozam @mahdiHash
Update text nodes
302d352 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update new line
02a3112 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update half spaces2
5a881a1 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update half spaces3
4ac9870 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update half spaces4
d1803a7 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update new line === line break
d6c1b79 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update into or with
41cc0c5 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update new line again
640e9d9 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update 2-ui/1-document/02-dom-nodes/article.md
bd26c7f 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update it's there
311540f 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update from
53df22c 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update inspect
dbab746 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update real-time
e4b0614 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update how it's looks
d03c865 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update node types
dcdc1c2 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdyar
Update comment
74b67b1 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@Beroozam @mahdiHash
Update comments for comments
964b409 
Co-authored-by: Mahdi Hashemi <[email protected]>
@Beroozam @mahdiHash
Update debugging
65c8abe 
Co-authored-by: Mahdi Hashemi <[email protected]>
Beroozam
Beroozam commented Jan 14, 2022
View reviewed changes
Copy link
Contributor Author

@Beroozam Beroozam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review needed

@mahdiHash
Fix line counts conflicts and remove a word
285af35 
For the uniformity of articles, "خلاصه مطلب" is changed to "خلاصه".
@mahdiHash
Remove an empty line
1d4a01a
mahdiHash
mahdiHash approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @Beroozam.

mahdyar
mahdyar approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mahdyar mahdyar merged commit 2f60a44 into javascript-tutorial:master Jan 14, 2022
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jan 14, 2022

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

+1 more reviewer

@mahdiHash mahdiHash mahdiHash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Beroozam @mahdiHash @javascript-translate-bot @mahdyar