Skip to content

Object methods, "this" #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mahdyar merged 23 commits into from
May 12, 2021
Merged

Object methods, "this" #122

mahdyar merged 23 commits into from
May 12, 2021

Conversation

@mahdiHash
Copy link
Contributor

@mahdiHash mahdiHash commented May 12, 2021

Please review and comment / commit if anything is wrong
And read the comments as you "see" them

@javascript-translate-bot javascript-translate-bot requested a review from a team May 12, 2021 09:03
@javascript-translate-bot javascript-translate-bot mentioned this pull request May 12, 2021
Open
mahdyar
mahdyar requested changes May 12, 2021
View reviewed changes
@javascript-translate-bot
Copy link

javascript-translate-bot commented May 12, 2021

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

mahdiHash and others added 9 commits May 12, 2021 16:17
@mahdiHash @mahdyar
Update 1-js/04-object-basics/04-object-methods/7-calculator/task.md
5c48b27 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash @mahdyar
Update 1-js/04-object-basics/04-object-methods/8-chain-calls/solution.md
1cd8587 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash @mahdyar
Update 1-js/04-object-basics/04-object-methods/8-chain-calls/solution.md
cad4331 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash @mahdyar
Update 1-js/04-object-basics/04-object-methods/8-chain-calls/task.md
b51bb94 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash @mahdyar
Update 1-js/04-object-basics/04-object-methods/article.md
ccffded 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash @mahdyar
Update 1-js/04-object-basics/04-object-methods/article.md
14e6dd9 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash @mahdyar
Update 1-js/04-object-basics/04-object-methods/article.md
08e4ef5 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash @mahdyar
Update 1-js/04-object-basics/04-object-methods/article.md
7c89baf 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash @mahdyar
Update 1-js/04-object-basics/04-object-methods/article.md
a17a2ce 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash
Copy link
Contributor Author

mahdiHash commented May 12, 2021

Thanks for your review @mahdyar
/done

@javascript-translate-bot javascript-translate-bot requested a review from a team May 12, 2021 11:52
@mahdyar
Copy link
Member

mahdyar commented May 12, 2021

Thanks for your review @mahdyar
/done

You could've added all the suggestions to a batch and make a single commit for all of them as well. :) [+]

Thank you, @mahdiHashemi14!

@mahdyar mahdyar merged commit f2332b1 into javascript-tutorial:master May 12, 2021
@javascript-translate-bot
Copy link

javascript-translate-bot commented May 12, 2021

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@mahdiHash
Copy link
Contributor Author

mahdiHash commented May 12, 2021

Thanks for your review @mahdyar
/done

You could've added all the suggestions to a batch and make a single commit for all of them as well. :) [+]

Thank you, @mahdiHashemi14!

Thank you for pro tip. I'll keep that in mind next time 😄👌🏻

@javascript-translate-bot javascript-translate-bot requested a review from a team May 12, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar