Refactor comment hierarchy in preparation for MarkdownComments#4885
Refactor comment hierarchy in preparation for MarkdownComments#4885jlerbsc merged 5 commits intojavaparser:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4885 +/- ##
===========================================
Coverage 58.383% 58.383%
Complexity 2534 2534
===========================================
Files 679 679
Lines 39066 39066
Branches 7085 7085
===========================================
Hits 22808 22808
Misses 13358 13358
Partials 2900 2900
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Thank you for your understanding. Can this PR be merged immediately? |
|
Regardless of this PR, could you please take the time to document in the project wiki the steps required to add a node to the AST or modify a class hierarchy? Thank you in advance. |
|
This can be merged already, yes (edit: alternatively this can wait until the markdown changes are ready, in case I missed anything) Regarding documentation, I added https://github.com/javaparser/javaparser/wiki/A-Detailed-Guide-to-Adding-New-Nodes-and-Fields when I implemented support for record pattern expressions. The steps for modifying the class hierarchy is mostly the same as adding new nodes with some extra care taken to update usage sites. The details of that depend on the particular change being made, however. |
OK i'll wait. |
Could you add a section for this type of modification, specifying the sequence of actions and the differences compared to adding a field? Perhaps you could use the example of comments to briefly detail these actions. |
|
I've opened johannescoetzee#3 on my fork to show the cleaned-up version of the MarkdownComment support PR. If that looks good, then this can be merged after which I'll open a PR for the same changes in this repo |
This PR introduces the comment hierarchy refactor which I added in some of the later commits in #4875.