Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4792 +/- ##
===========================================
Coverage 58.351% 58.351%
Complexity 2514 2514
===========================================
Files 671 671
Lines 38782 38782
Branches 7041 7041
===========================================
Hits 22630 22630
Misses 13266 13266
Partials 2886 2886
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| public Comment setContent(final String content) { | ||
| assertNotNull(content); | ||
| if (content == this.content) { | ||
| if (content.equals(this.content)) { |
There was a problem hiding this comment.
Can you explain how these classes were modified?
There was a problem hiding this comment.
I modified PropertyGenerator.generateSetter() to generate this whenever the property type is String, the code change is included in this PR.
After testing the generation manually in the working copy of my local repo, I copied the PropertyGenerator change to a second, pristine clone and then ran ./run_core_metamodel_generator.sh && ./run_core_generators.sh there.
Later I wrote the unit tests, copied those to the second checkout as well and re-ran the generator scripts.
Finally, I squashed all the changes from the second working copy and pushed the resulting commit.
Let me know if anything's missing, or if you prefer separate commits for any of the steps I took.
|
Thank you for your contribution. Could you simply separate the commit of the changes you made manually from those generated by the shell. |
|
Sure! Done. |
|
Thank you for this contribution. |
2 participants
Fixes #4791.