Fix resolution for method refs used as varargs#4759
Merged
jlerbsc merged 1 commit intojavaparser:masterfrom May 19, 2025
Merged
Fix resolution for method refs used as varargs#4759jlerbsc merged 1 commit intojavaparser:masterfrom
jlerbsc merged 1 commit intojavaparser:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4759 +/- ##
===============================================
+ Coverage 58.321% 58.326% +0.004%
- Complexity 2512 2514 +2
===============================================
Files 671 671
Lines 38780 38782 +2
Branches 7040 7041 +1
===============================================
+ Hits 22617 22620 +3
Misses 13271 13271
+ Partials 2892 2891 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is effectively the same thing as #4752, but for fixing a crash where a vararg
MethodReferenceExpris resolved as a method usage. The first change fixes anIndexOutOfBoundscrash, while the second fixes the same issue as in the linked PR where the resulting type is anArrayType(...)which breaks the rest of the resolution logic.