Fix resolution of lambdas used as varargs#4752
Merged
jlerbsc merged 1 commit intojavaparser:masterfrom May 12, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4752 +/- ##
===============================================
- Coverage 58.324% 58.319% -0.006%
- Complexity 2509 2511 +2
===============================================
Files 671 671
Lines 38764 38778 +14
Branches 7034 7039 +5
===============================================
+ Hits 22609 22615 +6
- Misses 13264 13271 +7
- Partials 2891 2892 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Collaborator
|
That sounds fine to me. Thank you for your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue I encountered when attempting to resolve lambdas that were used as varargs, for example the second argument in
At first this resulted in an
IndexOutOfBoundscrash when trying to get the type of the parameter with index 1. The fix for this was to makeMethodResolutionLogic.getMethodsExplicitAndVariadicParameterTypepublic and to use that to get the type (since this accounts for varargs already) and to add agetMethodUsageExplicitAndVariadicParameterTypeto do the same forMethodUsage.This fixed the
IndexOutOfBoundscrash, but resulted in a new issue whereacceptConsumerscouldn't be resolved. This is because, when getting the expected parameter type from the parent (in this case theacceptConsumerscall), the returned type is an array ofConsumerdue to the varargs. It's not possible for a lambda to define an array type, however, so the resolution fails. This broke the rest of the lambda resolution logic, so to fix it the type is now unwrapped and the component type is used instead.