Fix Switch toString to LexicalPreservingPrinter when configured#4712
Merged
jlerbsc merged 3 commits intojavaparser:masterfrom Apr 4, 2025
Merged
Fix Switch toString to LexicalPreservingPrinter when configured#4712jlerbsc merged 3 commits intojavaparser:masterfrom
jlerbsc merged 3 commits intojavaparser:masterfrom
Conversation
…gurable and non-configurable printers (e.g. the LexicalPreservingPrinter)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4712 +/- ##
===============================================
+ Coverage 58.200% 58.205% +0.004%
Complexity 2499 2499
===============================================
Files 670 671 +1
Lines 38721 38735 +14
Branches 7023 7028 +5
===============================================
+ Hits 22536 22546 +10
- Misses 13294 13295 +1
- Partials 2891 2894 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1821 .
Make the LPP the default printer when configured with parserConfiguration.setLexicalPreservationEnabled(true).
The previous method of using the LexicalPreservingPrinter remains operational to activate the lexical preservation printer while keeping the default pretty printer.
THIS IS A BREAKING CHANGE ON LEXICAL PRESERVING PRINTER USAGE.