Fix for #3710 by cutting off resolution loops involving object creation steps.#4704
Merged
jlerbsc merged 5 commits intojavaparser:masterfrom Apr 3, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4704 +/- ##
===============================================
- Coverage 58.198% 58.194% -0.005%
Complexity 2497 2497
===============================================
Files 670 670
Lines 38719 38720 +1
Branches 7022 7023 +1
===============================================
- Hits 22534 22533 -1
- Misses 13293 13295 +2
Partials 2892 2892
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
johanneskloos
force-pushed
the
johanneskloos/3710-infinite-recursion-involving-object-creation-scopes
branch
from
7bc20b7 to
dece4d5
Compare
jlerbsc
reviewed
Apr 2, 2025
| // is not the same as the current node. | ||
| while (notMethodNode instanceof MethodCallExpr | ||
| || notMethodNode instanceof FieldAccessExpr | ||
| || (notMethodNode instanceof ObjectCreationExpr && notMethodNode.hasScope()) |
Collaborator
There was a problem hiding this comment.
I'm not sure that the expression new A().new B() can be solved correctly.
Collaborator
There was a problem hiding this comment.
Please add a comment explaining simply and clearly why this has been added
Contributor
Author
There was a problem hiding this comment.
I have added a comment, and a unit test for the case you mentioned.
Contributor
Author
There was a problem hiding this comment.
In fact, I added two unit tests :)
jlerbsc
reviewed
Apr 2, 2025
| "com.github.javaparser.symbolsolver.Outer.make()", resolvedMethod.getQualifiedSignature()); | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Please include these classes in the source code to be parsed.
This is adapted from my own example and the example in 3710, to make up a more-or-less minimal reproduction case.
Without this check, the symbol resolver would loop between resolving a method call (used as scope argument for a new object creation) and resolving the method call's scope.
johanneskloos
force-pushed
the
johanneskloos/3710-infinite-recursion-involving-object-creation-scopes
branch
from
353f1ad to
c189a15
Compare
…ner class creation resolution with a constructor base work as expected.
johanneskloos
force-pushed
the
johanneskloos/3710-infinite-recursion-involving-object-creation-scopes
branch
from
c189a15 to
84441d0
Compare
Collaborator
|
Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3710.
The idea of the fix is that the scope in inner class object creation expressions, e.g.,
makeOuter().new Inner(), can cause resolution loops in just the same way that the scope of a field access or method call can, and should be handled in the same way.