Skip to content

Fix issue 4670 LexicalPreservingPrinter removed incorect token when removing modifier of a Parameter with annotations#4674

Merged
jlerbsc merged 2 commits intojavaparser:masterfrom
jlerbsc:master
Feb 11, 2025
Merged

Fix issue 4670 LexicalPreservingPrinter removed incorect token when removing modifier of a Parameter with annotations#4674
jlerbsc merged 2 commits intojavaparser:masterfrom
jlerbsc:master

Conversation

@jlerbsc
Copy link
Copy Markdown
Collaborator

@jlerbsc jlerbsc commented Feb 11, 2025

Fixes #4670 .

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.136%. Comparing base (01c51ae) to head (4007289).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##            master     #4674       +/-   ##
=============================================
+ Coverage   58.120%   58.136%   +0.015%     
=============================================
  Files          508       508               
  Lines        29776     29775        -1     
  Branches      5251      5251               
=============================================
+ Hits         17306     17310        +4     
+ Misses       10332     10329        -3     
+ Partials      2138      2136        -2     
Flag Coverage Δ
AlsoSlowTests 58.136% <100.000%> (+0.015%) ⬆️
javaparser-core 58.136% <100.000%> (+0.015%) ⬆️
javaparser-symbol-solver 58.136% <100.000%> (+0.015%) ⬆️
jdk-10 58.102% <100.000%> (+0.015%) ⬆️
jdk-11 58.102% <100.000%> (+0.015%) ⬆️
jdk-12 58.102% <100.000%> (+0.015%) ⬆️
jdk-13 58.102% <100.000%> (+0.015%) ⬆️
jdk-14 58.102% <100.000%> (+0.015%) ⬆️
jdk-15 58.102% <100.000%> (+0.015%) ⬆️
jdk-16 58.102% <100.000%> (+0.015%) ⬆️
jdk-17 58.102% <100.000%> (+0.015%) ⬆️
jdk-18 58.102% <100.000%> (+0.015%) ⬆️
jdk-8 58.105% <100.000%> (+0.015%) ⬆️
jdk-9 58.099% <100.000%> (+0.015%) ⬆️
macos-latest 58.125% <100.000%> (+0.015%) ⬆️
ubuntu-latest 58.125% <100.000%> (+0.015%) ⬆️
windows-latest 58.112% <100.000%> (+0.015%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...github/javaparser/printer/ConcreteSyntaxModel.java 99.260% <100.000%> (-0.001%) ⬇️
...alpreservation/ReshuffledDiffElementExtractor.java 95.035% <100.000%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438a7f0...4007289. Read the comment docs.

@jlerbsc jlerbsc merged commit 26189bd into javaparser:master Feb 11, 2025
34 checks passed
@jlerbsc jlerbsc added this to the 3.26.4 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LexicalPreservingPrinter removed incorect token when removing modifier of a Parameter with annotations.

1 participant