Fix issue #4607: don't forget to clone guard when cloning stmt.SwitchEntry#4608
Conversation
|
You must use mvn spotless:apply to format the code you commit. |
…tmt.SwitchEntry
61f1104 to
e055205
Compare
|
@jlerbsc thank you for pointing that out! Your suggestion made me realize that I need to have another look at CONTRIBUTING.md. There I saw the recommendation to run |
|
@johannescoetzee Do you agree with these changes? |
javaparser-core/src/main/java/com/github/javaparser/metamodel/JavaParserMetaModel.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4608 +/- ##
=============================================
+ Coverage 58.009% 58.099% +0.090%
=============================================
Files 508 508
Lines 29778 29780 +2
Branches 5253 5253
=============================================
+ Hits 17274 17302 +28
+ Misses 10366 10340 -26
Partials 2138 2138
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
This looks good to me! Adding the Edit: The fact that the style check passed for the current iteration also means there are no manual changes in the PR that will be overwritten by the code generators |
|
Thank you for this contribution. |
|
Thank you for reviewing it so quickly! |
Fixes #4607.