Skip to content

Add missing copyright notice to RecordPatternExpr.java#4527

Merged
jlerbsc merged 5 commits intojavaparser:masterfrom
johannescoetzee:johannes/copyright
Aug 16, 2024
Merged

Add missing copyright notice to RecordPatternExpr.java#4527
jlerbsc merged 5 commits intojavaparser:masterfrom
johannescoetzee:johannes/copyright

Conversation

@johannescoetzee
Copy link
Copy Markdown
Collaborator

@johannescoetzee johannescoetzee commented Aug 14, 2024

I missed this in the original PR adding support for record patterns

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.859%. Comparing base (7d94568) to head (0fcaf2e).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #4527   +/-   ##
=========================================
  Coverage   57.859%   57.859%           
=========================================
  Files          508       508           
  Lines        29774     29774           
  Branches      5253      5253           
=========================================
  Hits         17227     17227           
  Misses       10416     10416           
  Partials      2131      2131
Flag Coverage Δ
AlsoSlowTests 57.859% <ø> (ø)
javaparser-core 57.859% <ø> (ø)
javaparser-symbol-solver 57.859% <ø> (ø)
jdk-10 57.812% <ø> (ø)
jdk-11 57.825% <ø> (ø)
jdk-12 57.812% <ø> (ø)
jdk-13 57.825% <ø> (ø)
jdk-14 57.812% <ø> (ø)
jdk-15 57.825% <ø> (ø)
jdk-16 57.825% <ø> (ø)
jdk-17 57.825% <ø> (ø)
jdk-18 57.825% <ø> (ø)
jdk-8 57.828% <ø> (ø)
jdk-9 57.812% <ø> (ø)
macos-latest 57.849% <ø> (ø)
ubuntu-latest 57.835% <ø> (ø)
windows-latest 57.835% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../github/javaparser/ast/expr/RecordPatternExpr.java 66.666% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a23a49...0fcaf2e. Read the comment docs.

@jlerbsc
Copy link
Copy Markdown
Collaborator

jlerbsc commented Aug 14, 2024

There is a spotless check error!

@johannescoetzee
Copy link
Copy Markdown
Collaborator Author

johannescoetzee commented Aug 15, 2024

Hmm, I ran ./mvnw spotless:apply before creating this PR, but in this case it wasn't enough since the check in PRs also re-run the code generators. I've fixed this now and will follow this PR up with one that adds a maven format rule or something that also runs the generators and update documentation to mention that

@jlerbsc jlerbsc merged commit b8a9a5a into javaparser:master Aug 16, 2024
@jlerbsc jlerbsc added this to the next release milestone Aug 16, 2024
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Aug 16, 2024
@johannescoetzee johannescoetzee mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Fixed A PR that offers a fix or correction

Projects

None yet

Milestone

3.26.2

Development

Successfully merging this pull request may close these issues.

2 participants

@johannescoetzee @jlerbsc