Add missing type erasure in ClassOrInterfaceType.toDescriptor#4522
Merged
jlerbsc merged 3 commits intojavaparser:masterfrom Aug 14, 2024
Merged
Conversation
johanneskloos
force-pushed
the
johanneskloos/4519-add-missing-type-erasure
branch
from
25dfcc0 to
5799942
Compare
top-level type variables.
use the erased type. This matches up with the requirement that descriptors reference binary names of objects, and may not contain generic information.
johanneskloos
force-pushed
the
johanneskloos/4519-add-missing-type-erasure
branch
from
5799942 to
4d54d9b
Compare
Collaborator
|
This PR seems correct to me. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4519.
This fixes a bug in
toDescriptorwhere we try to derive binary names of non-erased types (which may be type variables or wildcards, and therefore not have binary names) by always looking at the erasure.