Allow primitive types for patterns#4506
Merged
jlerbsc merged 1 commit intojavaparser:masterfrom Jul 22, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4506 +/- ##
=============================================
+ Coverage 57.854% 57.859% +0.004%
=============================================
Files 508 508
Lines 29773 29774 +1
Branches 5253 5253
=============================================
+ Hits 17225 17227 +2
+ Misses 10417 10416 -1
Partials 2131 2131
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Collaborator
|
Thank you for this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4504.
The type of a PatternExpr has been represented by a reference type until now, which was correct before the introduction of record patterns (since a top level pattern type must always be a reference type from https://docs.oracle.com/javase/specs/jls/se21/html/jls-14.html#jls-Pattern), but now nested type patterns may have a primitive type as well. The type of a record pattern expr must still be a reference type since there aren't primitive records in java.
This PR updates the type of a pattern to reflect this, which includes making a necessary API change.