Exclude unavailable macos <-> java version combinations from github tests#4479
Merged
jlerbsc merged 3 commits intojavaparser:masterfrom Jun 24, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4479 +/- ##
=========================================
Coverage 57.877% 57.877%
=========================================
Files 507 507
Lines 29737 29737
Branches 5245 5245
=========================================
Hits 17211 17211
Misses 10395 10395
Partials 2131 2131
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
jlerbsc
added
the
PR: Changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR excludes the java versions currently failing on macos from the list of distributions that are tested. I went through the list of supported distributions on https://github.com/actions/setup-java (both the versions they mention there and the release archives for each distribution) and none of them seem to support these EoL versions.
I'm sure there is a way to test these versions, but it will likely take a fair amount of work to set this up. Until this is done (if it does happen), I think it is better to exclude these versions for 2 reasons: