Disable spotless ratcheting and fix formatting#4478
Merged
jlerbsc merged 2 commits intojavaparser:masterfrom Jun 21, 2024
Merged
Disable spotless ratcheting and fix formatting#4478jlerbsc merged 2 commits intojavaparser:masterfrom
jlerbsc merged 2 commits intojavaparser:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the formatting issue that caused the spotless check in #4477 to fail, but also disables the spotless ratcheting feature. With ratcheting enabled, spotless will only check and reformat files that differ from the versions on the master branch, but that makes fixing inconsistencies that have been merged to master more difficult and can hide issues that have already been merged.