Automatically format code after codegen and validate with a github action#4468
Merged
jlerbsc merged 2 commits intojavaparser:masterfrom Jun 12, 2024
Merged
Conversation
Collaborator
|
I'm not a specialist in github shares, but it looks fine to me. Thanks for the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final PR related to #4408
This PR includes 2 changes:
I tested this in johannescoetzee#1. Some of the later commits are missing since I cleaned up the branch for this PR, but the relevant github jobs were:
Working run
https://github.com/johannescoetzee/javaparser/actions/runs/9485459827/job/26137443518?pr=1
Incorrect formatting
https://github.com/johannescoetzee/javaparser/actions/runs/9485678529/job/26138198159?pr=1
Fixed again
https://github.com/johannescoetzee/javaparser/actions/runs/9485811857/job/26138677223?pr=1
Missing generated code
https://github.com/johannescoetzee/javaparser/actions/runs/9485852607/job/26138825304?pr=1
We could potentially remove the checkstyle job, but I'm not sure whether that checks anything not covered by spotless. I'll do a bit of research on that.