Add git-blame-ignore-revs file to ignore the reformatting commit in git blame#4466
Merged
jlerbsc merged 1 commit intojavaparser:masterfrom Jun 12, 2024
Merged
Conversation
jlerbsc
added
PR: Added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation is discussed in #4408
With this file in place, github will ignore 5106428 for determining where a change was made. For git cli,
git config blame.ignoreRevFileneeds to be used to configure this.An example of this working can be found at https://github.com/johannescoetzee/javaparser/blame/johannes/git-blame-ignore/javaparser-core/src/main/java/com/github/javaparser/CommentsInserter.java (just an arbitrary file I chose on the relevant branch on my fork).