Fix record declarations nested in annotation declarations#4460
Merged
jlerbsc merged 2 commits intojavaparser:masterfrom Jun 6, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4460 +/- ##
=============================================
+ Coverage 51.999% 52.003% +0.003%
=============================================
Files 507 507
Lines 28654 28654
Branches 4969 4969
=============================================
+ Hits 14900 14901 +1
+ Misses 11685 11684 -1
Partials 2069 2069
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
johannescoetzee
changed the title
jlerbsc
added
the
PR: Added
Collaborator
|
Thank you for your attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the grammar
it is possible to declare a record as a child of an annotation declaration, but this case is currently not handled, leading to parse errors. This PR adds that case to the JavaParser grammar with some tests. I added the lpp test to make sure it works, but no fixes were required there.
(I discovered this issue when parsing some larger projects to see if there are any more switch-related bugs, but this is an older bug that is unrelated to any recent changes)