Fix missed generated code from PatternExpr refactor#4414
Merged
jlerbsc merged 2 commits intojavaparser:masterfrom May 6, 2024
Merged
Fix missed generated code from PatternExpr refactor#4414jlerbsc merged 2 commits intojavaparser:masterfrom
jlerbsc merged 2 commits intojavaparser:masterfrom
Conversation
jlerbsc
added
PR: Added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the
RecordPatternExprfeature, I noticed that I missed some generated code while filtering style changes from actual changes in #4387. For this PR, I just re-ran the core metamodel generator and core generators again and added the relevant changes.I would like to draw attention to my reformatting proposal (see #4408) as well. I understand that reformatting the entire project is not a decision to be taken lightly, but I think it is important to prevent mistakes like these while also making contributions easier. The approach I mentioned in the issue is of course just one approach and I'm open to any suggestions on how to improve it. Even if that approach isn't chosen, I hope that my ideas on how to minimise the impact of such a change are of some use.