Skip to content

Refactor ResolvedReferenceType#equals#4351

Merged
jlerbsc merged 1 commit intojavaparser:masterfrom
freya022:fix/lazy-type-equals2
Mar 20, 2024
Merged

Refactor ResolvedReferenceType#equals#4351
jlerbsc merged 1 commit intojavaparser:masterfrom
freya022:fix/lazy-type-equals2

Conversation

@freya022
Copy link
Copy Markdown
Contributor

Fixes #4350.

Fixes comparing against lazy types
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 51.844%. Comparing base (289b2d4) to head (b3c51cc).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##            master     #4351       +/-   ##
=============================================
- Coverage   51.847%   51.844%   -0.004%     
=============================================
  Files          497       497               
  Lines        28333     28335        +2     
  Branches      4915      4917        +2     
=============================================
  Hits         14690     14690               
- Misses       11602     11604        +2     
  Partials      2041      2041               
Flag Coverage Δ
AlsoSlowTests 51.844% <0.000%> (-0.004%) ⬇️
javaparser-core 51.844% <0.000%> (-0.004%) ⬇️
javaparser-symbol-solver 51.844% <0.000%> (-0.004%) ⬇️
jdk-10 51.840% <0.000%> (+0.006%) ⬆️
jdk-11 51.840% <0.000%> (-0.004%) ⬇️
jdk-12 51.840% <0.000%> (-0.004%) ⬇️
jdk-13 51.840% <0.000%> (-0.004%) ⬇️
jdk-14 51.840% <0.000%> (+0.006%) ⬆️
jdk-15 51.840% <0.000%> (-0.004%) ⬇️
jdk-16 51.840% <0.000%> (-0.004%) ⬇️
jdk-17 51.840% <0.000%> (-0.004%) ⬇️
jdk-18 51.840% <0.000%> (-0.004%) ⬇️
jdk-8 51.838% <0.000%> (-0.004%) ⬇️
jdk-9 51.840% <0.000%> (-0.004%) ⬇️
macos-latest 51.836% <0.000%> (-0.004%) ⬇️
ubuntu-latest 51.836% <0.000%> (-0.004%) ⬇️
windows-latest 51.822% <0.000%> (-0.004%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...parser/resolution/types/ResolvedReferenceType.java 0.000% <0.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ca785...b3c51cc. Read the comment docs.

@jlerbsc jlerbsc merged commit feba579 into javaparser:master Mar 20, 2024
@jlerbsc jlerbsc added this to the next release milestone Mar 20, 2024
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Mar 20, 2024
@jlerbsc
Copy link
Copy Markdown
Collaborator

jlerbsc commented Mar 20, 2024

Thank you for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Fixed A PR that offers a fix or correction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to check equality of ResolvedReferenceType with a LazyType

2 participants