feat: add support for fido keybind - #89
Conversation
|
Looks good in general, another 10/10 PR. Will merge this shortly after I double check all security stuff and the UI things (each time I add something it needs even more a rewrite). Also I need to add documentation with this. And if you don't mind, where do you usually find useful PAM documentation?? It was a hassle to implement the primitive current one. |
reading sudo, login, or ly source |
|
I'm gonna merge this regardless but is the yubikey implementation literally the same as if it tried to login with an empty password? Does that mean that just pressing enter also works? |
pressing enter with empty password will trigger pam_u2f if configured and device is present, otherwise auth fails, so yeah i guess just a convenience if theres something already in the password field? |
|
I think a better cfg name would be related to "empty password login" or something similar. But unless there's a need for such a keybind for other things, I think saying its for yubikeys its fine. Also don't mind if I push some docs to your branch. |
|
im actually gonna finally make a minor release with all the latest changes for once in a lil while, ive been delaying this too much already |
Disabled by default, enable with
fido = F3in configRequires
pam_u2fconfigured with a registered key (pamu2fcfgoutput in~/.config/Yubico/u2f_keysor system-wide).Tested with YubiKey C Bio - FIDO Edition and YubiKey 5C NFC
Tested on Arch Linux, Hyprland using 6.17.11-lqx1-1-lqx
forgot to mention i tested this with