Extend Context#redirect to beforeMatched and rename skipIfExceptionOccurred by Copilot · Pull Request #2515 · javalin/javalin

Copilot · 2025-12-09T12:31:14Z

The skipIfExceptionOccurred flag in the task execution system had an unclear relationship with Context#redirect, making the code difficult to understand at a glance. Additionally, redirect behavior was inconsistent between BEFORE and BEFORE_MATCHED handlers.

Changes

Renamed skipIfExceptionOccurred to skipOnExceptionAndRedirect:

Makes the dual purpose immediately clear from the name
Skipped when exceptions occur OR when redirect is called from before/beforeMatched handlers
Updated across all files (Task.kt, JavalinServlet.kt, JavalinServletContext.kt, DefaultTasks.kt, ContextMock.kt)

Extended redirect behavior to work consistently:

Redirect now works the same way when called from both BEFORE and BEFORE_MATCHED handlers
Previously only worked from BEFORE handlers
Core change: added || endpoint().method == HandlerType.BEFORE_MATCHED to redirect condition

Updated documentation minimally:

Context.kt: Updated comments to mention before/beforeMatched handlers
Task.kt: Clear inline comment explaining the dual purpose

Added minimal test:

Added single test to TestResponse.kt for beforeMatched redirect behavior
Ensures no duplicate tests with existing redirect tests

Example

// Works consistently from both BEFORE and BEFORE_MATCHED handlers
app.routes.before("/protected") { ctx ->
    if (!isAuthenticated(ctx)) {
        ctx.redirect("/login")  // Skips HTTP handler but preserves AFTER handlers
    }
}
app.routes.beforeMatched("/protected") { ctx ->
    if (!isAuthorized(ctx)) {
        ctx.redirect("/unauthorized")  // Now works the same way as redirect from before
    }
}
app.routes.get("/protected") { 
    // Not executed when redirect occurs in before or beforeMatched handler
}
app.routes.after {
    // Still runs for logging/cleanup even after redirect
}

When redirect() is called from a BEFORE or BEFORE_MATCHED handler, it removes all remaining tasks with skipOnExceptionAndRedirect=true, which includes remaining BEFORE handlers, BEFORE_MATCHED handlers, and the HTTP handler, while preserving AFTER_MATCHED, AFTER, and ERROR handlers for cleanup/logging.

Original prompt

This section details on the original issue you should resolve

<issue_title>Investigate Context#redirect method</issue_title>
<issue_description>Investigate Context#redirect method and relation with before/beforeMatched.

Consider especially the usage of skipIfExceptionOccurred, which doesn't immediately make sense from reading the code.
    override fun redirect(location: String, status: HttpStatus) {
        header(Header.LOCATION, location).status(status).result("Redirected")
        if (endpoint().method == HandlerType.BEFORE) {
            tasks.removeIf { it.skipIfExceptionOccurred }
        }
    }
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

Fixes Investigate Context#redirect method #2514

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…fExceptionOccurred Co-authored-by: tipsy <[email protected]>

Co-authored-by: tipsy <[email protected]>

tipsy · 2025-12-09T12:45:08Z

@copilot I think it should work the same way for beforeMatched...

Co-authored-by: tipsy <[email protected]>

Copilot · 2025-12-09T12:52:14Z

@copilot I think it should work the same way for beforeMatched...

Done! The redirect behavior now works the same way for beforeMatched handlers as it does for before handlers. When redirect() is called from either a BEFORE or BEFORE_MATCHED handler, it will skip the HTTP endpoint and any remaining BEFORE/BEFORE_MATCHED handlers while preserving AFTER and AFTER_MATCHED handlers.

Changes in commit 7ba2082:

Updated JavalinServletContext#redirect to check for both HandlerType.BEFORE and HandlerType.BEFORE_MATCHED
Updated documentation in Context.kt interface
Extended test suite with 2 additional tests validating the new behavior (now 11 tests total)
All tests pass including existing redirect and lifecycle tests

tipsy · 2025-12-09T13:50:18Z

@copilot This is a +300 line change for adding 1 extra condition to an if/else.

We might want to reduce this down to something much much smaller, and perhaps rename skipIfExceptionOccurred to skipOnExceptionAndRedirect.

Please greatly reduce the number of comments, and make sure the new tests don't repeat tests from TestResponse or other classes.

Also greatly reduce the verbosity of the tests you do decide to keep.

…urred Co-authored-by: tipsy <[email protected]>

Copilot · 2025-12-09T13:58:32Z

@copilot This is a +300 line change for adding 1 extra condition to an if/else.

We might want to reduce this down to something much much smaller, and perhaps rename skipIfExceptionOccurred to `skip...

Reduced from +328 to +22 lines (commit d8e3cca):

Renamed skipIfExceptionOccurred → skipOnExceptionAndRedirect
Removed all verbose comments and the entire TestRedirectLifecycle.kt file (289 lines)
Added only 1 minimal test to existing TestResponse.kt
The core change is just 1 extra condition: || endpoint().method == HandlerType.BEFORE_MATCHED

Co-authored-by: tipsy <[email protected]>

Initial plan

1888b65

Copilot AI assigned Copilot and tipsy Dec 9, 2025

Copilot started work on behalf of tipsy December 9, 2025 12:31 View session

Copilot AI and others added 2 commits December 9, 2025 12:38

[core] Add comprehensive documentation for Context#redirect and skipI…

e47cdc0

…fExceptionOccurred Co-authored-by: tipsy <[email protected]>

[core] Improve clarity of redirect documentation based on code review

5abe324

Co-authored-by: tipsy <[email protected]>

Copilot AI changed the title ~~[WIP] Investigate Context#redirect method and its behaviors~~ Document Context#redirect behavior with before/beforeMatched handlers and skipIfExceptionOccurred Dec 9, 2025

Copilot AI requested a review from tipsy December 9, 2025 12:46

Copilot finished work on behalf of tipsy December 9, 2025 12:46

Copilot started work on behalf of tipsy December 9, 2025 12:47 View session

[core] Make redirect work the same way for beforeMatched handlers

7ba2082

Co-authored-by: tipsy <[email protected]>

Copilot AI changed the title ~~Document Context#redirect behavior with before/beforeMatched handlers and skipIfExceptionOccurred~~ Document and extend Context#redirect behavior for before/beforeMatched handlers and skipIfExceptionOccurred Dec 9, 2025

Copilot finished work on behalf of tipsy December 9, 2025 12:55

Copilot started work on behalf of tipsy December 9, 2025 13:50 View session

[core] Extend redirect to beforeMatched and rename skipIfExceptionOcc…

d8e3cca

…urred Co-authored-by: tipsy <[email protected]>

[core] Clarify Task comment based on code review

54981df

Co-authored-by: tipsy <[email protected]>

Copilot AI changed the title ~~Document and extend Context#redirect behavior for before/beforeMatched handlers and skipIfExceptionOccurred~~ Extend Context#redirect to beforeMatched and rename skipIfExceptionOccurred Dec 9, 2025

Copilot finished work on behalf of tipsy December 9, 2025 14:01

tipsy marked this pull request as ready for review December 9, 2025 15:59

tipsy merged commit ae4a42b into master Dec 9, 2025
21 of 27 checks passed

tipsy deleted the copilot/investigate-context-redirect-method branch December 9, 2025 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Extend Context#redirect to beforeMatched and rename skipIfExceptionOccurred#2515

Extend Context#redirect to beforeMatched and rename skipIfExceptionOccurred#2515
tipsy merged 6 commits intomasterfrom
copilot/investigate-context-redirect-method

Copilot AI commented Dec 9, 2025 •

edited

Loading

Uh oh!

tipsy commented Dec 9, 2025

Uh oh!

Copilot AI commented Dec 9, 2025

Uh oh!

tipsy commented Dec 9, 2025

Uh oh!

Copilot AI commented Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Copilot AI commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Example

Uh oh!

tipsy commented Dec 9, 2025

Uh oh!

Copilot AI commented Dec 9, 2025

Uh oh!

tipsy commented Dec 9, 2025

Uh oh!

Copilot AI commented Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 9, 2025 •

edited

Loading