Skip to content

[core] Add config option to disable old version check warning #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tipsy merged 3 commits into from
Nov 12, 2025
Merged

[core] Add config option to disable old version check warning #2499

tipsy merged 3 commits into from
Nov 12, 2025

Conversation

Copy link
Contributor

Copilot AI commented Nov 12, 2025 •
edited
Loading

Adds showOldJavalinVersionWarning configuration option to suppress the "Your Javalin version is X days old" message while retaining version information in startup logs.

Changes

  • JavalinConfig: Added showOldJavalinVersionWarning boolean field (defaults to true)
  • Util: Modified logJavalinVersion() and formatBuildTime() to accept showVersionWarning parameter
  • JettyServer: Pass config value to version logging call

Usage

Javalin.create(config -> {
    config.showOldJavalinVersionWarning = false;
});

The version line "You are running Javalin X.Y.Z (released ...)" still appears, only the "X days old. Consider checking for a newer version." suffix is suppressed.

[!WARNING]

Original prompt

This section details on the original issue you should resolve

<filter_complete></filter_complete>

<issue_title>Add config option to disable old version check</issue_title>
<issue_description>Describe your issue</issue_description>

Comments on the Issue (you are @copilot in this section)

Original prompt

This section details on the original issue you should resolve

<issue_title>Add config option to disable old version check</issue_title>
<issue_description>Describe your issue</issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add config option to disable old version check [core] Add config option to disable old version check warning Nov 12, 2025
Copilot AI requested a review from tipsy November 12, 2025 09:51
@tipsy
Copy link
Member

tipsy commented Nov 12, 2025

@copilot it should probably be showOldJavalinVersionWarning

Copy link
Contributor Author

Copilot AI commented Nov 12, 2025

@copilot it should probably be showOldJavalinVersionWarning

Renamed to showOldJavalinVersionWarning in commit ce4761c. All tests pass.

@tipsy tipsy marked this pull request as ready for review November 12, 2025 21:11
@tipsy tipsy merged commit d011e39 into master Nov 12, 2025
24 checks passed
@tipsy tipsy deleted the copilot/add-disable-old-version-check branch November 12, 2025 21:21
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.29%. Comparing base (8c46e83) to head (ce4761c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
javalin/src/main/java/io/javalin/util/Util.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2499   +/-   ##
=========================================
  Coverage     86.28%   86.29%           
+ Complexity     1445     1443    -2     
=========================================
  Files           151      151           
  Lines          4179     4180    +1     
  Branches        477      477           
=========================================
+ Hits           3606     3607    +1     
  Misses          377      377           
  Partials        196      196

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tipsy tipsy Awaiting requested review from tipsy

Assignees

@tipsy tipsy

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add config option to disable old version check

2 participants

@tipsy