Skip to content

Conversation

@tipsy
Copy link
Member

@tipsy tipsy commented Oct 20, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.35%. Comparing base (1ab4d19) to head (7d662ba).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...valin/src/main/java/io/javalin/router/Endpoints.kt 72.72% 0 Missing and 3 partials ⚠️
...a/io/javalin/http/servlet/JavalinServletContext.kt 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2486      +/-   ##
============================================
+ Coverage     86.32%   86.35%   +0.02%     
- Complexity     1427     1454      +27     
============================================
  Files           148      149       +1     
  Lines          4572     4611      +39     
  Branches        486      503      +17     
============================================
+ Hits           3947     3982      +35     
- Misses          401      402       +1     
- Partials        224      227       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@dzikoysk dzikoysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach, a few comments but I guess it may I work. I wonder what's the difference in performance between this and the previous implementation.

@tipsy tipsy merged commit e3de3a9 into master Oct 22, 2025
20 checks passed
@tipsy tipsy deleted the endpoints branch October 22, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants