[javalin] Move routing to config #2479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors Javalin's routing API by moving route definitions from the Javalin instance to a new config.routes configuration object. The change shifts from app.get("/path") to config.routes.get("/path") within the create block, centralizing route configuration and aligning it with other framework settings.
Key Changes:
- Introduces a new
RoutesConfigclass that provides direct access to HTTP verbs and routing methods - Routes are now defined within the
Javalin.createconfiguration block usingconfig.routes.* - Removes routing methods from the
Javalinclass itself (no longer implementsJavalinDefaultRoutingApi) - Updates all example files, tests, and plugins to use the new routing API
Reviewed Changes
Copilot reviewed 129 out of 129 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| javalin/src/main/java/io/javalin/config/RoutesConfig.kt | New configuration class providing routing API within config blocks |
| javalin/src/main/java/io/javalin/config/JavalinConfig.kt | Adds routes field to expose the new RoutesConfig |
| javalin/src/main/java/io/javalin/Javalin.java | Removes routing methods, no longer implements JavalinDefaultRoutingApi |
| javalin/src/main/java/io/javalin/config/RouterConfig.kt | Removes deprecated mount() and apiBuilder() methods |
| javalin/src/test/java/io/javalin/testing/JavalinTestUtil.java | New utility providing app.verb() syntax for tests via static methods |
| javalin/src/test/java/io/javalin/testing/JavalinTestExtensions.kt | Extension functions maintaining app.verb() syntax for Kotlin tests |
| javalin/src/test/kotlin/io/javalin/examples/*.kt | Updates example files to use config.routes API |
| javalin/src/main/java/io/javalin/plugin/bundled/*.kt | Updates plugins to use config.routes for route registration |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2479 +/- ##
============================================
- Coverage 86.41% 86.32% -0.10%
+ Complexity 1462 1450 -12
============================================
Files 149 150 +1
Lines 4668 4658 -10
Branches 490 490
============================================
- Hits 4034 4021 -13
- Misses 409 412 +3
Partials 225 225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Copilot AI
added a commit
that referenced
this pull request
Oct 16, 2025
Co-authored-by: tipsy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.