[ssl] Drop Conscrypt ALPN support from SSL Plugin #2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tipsy <[email protected]>
Copilot
AI
changed the title
[WIP] Drop Conscript support in SSL Plugin
[ssl] Drop Conscrypt ALPN support from SSL Plugin
Sep 21, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2464 +/- ##
=========================================
Coverage 86.47% 86.47%
Complexity 1432 1432
=========================================
Files 147 147
Lines 4600 4600
Branches 479 479
=========================================
Hits 3978 3978
Misses 404 404
Partials 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Conscrypt ALPN dependency from the Javalin SSL Plugin and bundle, as requested for the 7.x release.
Background
The SSL plugin currently includes
jetty-alpn-conscrypt-serveras a dependency in both thejavalin-sslmodule andjavalin-bundle, but this dependency was never actually used in the codebase. The SSL plugin already uses Jetty's standard ALPN implementation (ALPNServerConnectionFactoryfromorg.eclipse.jetty.alpn.server) which provides all necessary HTTP/2 and ALPN functionality without requiring Conscrypt.Changes
jetty-alpn-conscrypt-serverdependency fromjavalin-ssl/pom.xmljetty-alpn-conscrypt-serverdependency fromjavalin-bundle/pom.xmlValidation
The removal has been thoroughly tested:
Started oejs.ServerConnector@...{SSL, (ssl, alpn, h2, http/1.1)}Impact
This change is fully backward compatible since Conscrypt was never actively used. The SSL plugin continues to provide the same ALPN and HTTP/2 capabilities through Jetty's standard implementation, which is the recommended approach for modern Java applications. This reduces the dependency footprint and potential security surface area without any functional impact.
Fixes #2113.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://storage.googleapis.com/chrome-for-testing-public/140.0.7339.185/linux64/chromedriver-linux64.zipREDACTED, pid is -1(http block)wronghost/usr/lib/jvm/temurin-17-jdk-amd64/bin/java -javaagent:/home/REDACTED/.m2/repository/org/jacoco/org.jacoco.agent/0.8.13/org.jacoco.agent-0.8.13-runtime.jar=destfile=/home/REDACTED/work/javalin/javalin/javalin-ssl/target/jacoco.exec -jar /home/REDACTED/work/javalin/javalin/javalin-ssl/target/surefire/surefirebooter-20250921153919702_3.jar /home/REDACTED/work/javalin/javalin/javalin-ssl/target/surefire 2025-09-21T15-39-19_629-jvmRun1 surefire-20250921153919702_1tmp surefire_0-20250921153919702_2tmp(dns block)/usr/lib/jvm/temurin-17-jdk-amd64/bin/java -javaagent:/home/REDACTED/.m2/repository/org/jacoco/org.jacoco.agent/0.8.13/org.jacoco.agent-0.8.13-runtime.jar=destfile=/home/REDACTED/work/javalin/javalin/javalin-ssl/target/jacoco.exec -jar /home/REDACTED/work/javalin/javalin/javalin-ssl/target/surefire/surefirebooter-20250921154127446_3.jar /home/REDACTED/work/javalin/javalin/javalin-ssl/target/surefire 2025-09-21T15-41-27_369-jvmRun1 surefire-20250921154127446_1tmp surefire_0-20250921154127446_2tmp(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.