Add onUpgrade method to WebSocket RequestLogger #2450
Conversation
Co-authored-by: tipsy <[email protected]>
onUpgrade
| /** | ||
| * Get the WebSocket upgrade logger, if configured | ||
| */ | ||
| public WsUpgradeLogger getWsUpgradeLogger() { | ||
| return wsUpgradeLogger; | ||
| } |
| /** | ||
| * Add a WsUpgradeLogger to the WsHandler. | ||
| * The handler is called when an HTTP request attempts to upgrade to WebSocket. | ||
| * This is invoked before the upgrade process begins, whether the upgrade succeeds or fails. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2450 +/- ##
============================================
+ Coverage 86.26% 86.39% +0.13%
- Complexity 1318 1435 +117
============================================
Files 148 148
Lines 4506 4587 +81
Branches 514 490 -24
============================================
+ Hits 3887 3963 +76
- Misses 400 407 +7
+ Partials 219 217 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| cfg = servletContextConfig, | ||
| req = req, | ||
| res = res, | ||
| matchedPath = requestUri, |
There was a problem hiding this comment.
This should probably be null, since it didn't match a path.
| req = req, | ||
| res = res, | ||
| matchedPath = requestUri, | ||
| pathParamMap = emptyMap(), |
There was a problem hiding this comment.
Maybe these empty maps could be default args, so the whole statement could be val upgradeContext = JavalinWsServletContext(servletContextConfig, req, res)
| pathParamMap = emptyMap(), | ||
| routeRoles = emptySet(), | ||
| ) | ||
| val executionTimeMs = (System.nanoTime() - requestStartTime) / 1_000_000.0f |
There was a problem hiding this comment.
Could we pull this out to a function? We are using it somewhere else too.
|
@copilot please update your PR based on the review comments. |
Co-authored-by: tipsy <[email protected]>
I've addressed all the review feedback:
All changes tested and WebSocket tests passing. Commit: 55b0504 |
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.