[context] add support for quoted charset in content-type header (#2448) #2449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi, just checking in to see if there’s any feedback on this PR. Happy to adjust if needed! |
Member
|
Hi @Pinusar, this looks good. Nice test! Will merge it now and release as part of Javalin 7. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2449 +/- ##
=========================================
Coverage 86.31% 86.31%
Complexity 1339 1339
=========================================
Files 148 148
Lines 4524 4524
Branches 515 515
=========================================
Hits 3905 3905
Misses 402 402
Partials 217 217 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix regarding quoted charset parameter in content-type header.
Content-type headers like
application/json;charset="utf-8"were causing errors.Changed content-type header parsing to handle both quoted and unquoted values and added a parameterized test for verification.
Fixes #2448