I tried to add some tests, but I am unable to fix these tests that are failing:
[ERROR] Run 1: TestCompression.assure preferred compressor is respected (gzip):487 » Runtime java.lang.Exception: Assertion error: expected: "gzip" but was: "br" [ERROR] Run 2: TestCompression.assure preferred compressor is respected (gzip):487 » Runtime java.lang.Exception: Assertion error: expected: "gzip" but was: "br" [ERROR] Run 3: TestCompression.assure preferred compressor is respected (gzip):487 » Runtime java.lang.Exception: Assertion error: expected: "gzip" but was: "br"

Basically I set the preferred list to this:

preferredCompressors(listOf(
        CompressionType.GZIP, CompressionType.BR
    )

so GZIP is preferred over Brotli, but for some reason I am getting Brotli as response (even when the request is send with both gzip and br), is the findMatchingCompressor function that I edited in JettyPrecompressingResourceHandler.kt being called for this test? Could you help me fixing this one?

Could you help me fixing this one?

Hi @fabiobento512 - it looks like you only added this for precompressed files, I think you are probably testing this for "live" compression in your tests.

Could you help me fixing this one?

Hi @fabiobento512 - it looks like you only added this for precompressed files, I think you are probably testing this for "live" compression in your tests.

Thank you! That was it! The tests that I initially mentioned are now passing. Please have a look at all the changes and see if there is still something else that needs work. 🙂

@fabiobento512 looks good ! There is a bit of duplication here, could you rewrite to remove it?

@fabiobento512 looks good ! There is a bit of duplication here, could you rewrite to remove it?

Thanks! I have now tried to remove the code duplication. Please check if it is ok (I moved a common function to the CompressionStrategy class).

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.47%. Comparing base (f840be8) to head (f91b2b3).
⚠️ Report is 1 commits behind head on master.

@@             Coverage Diff              @@
##             master    #2427      +/-   ##
============================================
- Coverage     86.47%   86.47%   -0.01%     
- Complexity     1432     1437       +5     
============================================
  Files           147      147              
  Lines          4600     4607       +7     
  Branches        479      481       +2     
============================================
+ Hits           3978     3984       +6     
  Misses          404      404              
- Partials        218      219       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Looks great, thank you very much @fabiobento512 - this will be part of Javalin 7!