Map client aborts to 499 and timeouts to 408. #2385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, both were returned as 500, mixing them with genuine server errors. Now, client disconnects are tracked as 499 (Client Closed Request), and request timeouts produce 408 (Request Timeout) to better categorize errors in logs and monitoring tools.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2385 +/- ##
============================================
- Coverage 87.15% 87.11% -0.05%
- Complexity 1322 1323 +1
============================================
Files 148 148
Lines 4470 4478 +8
Branches 513 514 +1
============================================
+ Hits 3896 3901 +5
- Misses 354 358 +4
+ Partials 220 219 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This looks really great @martinsk82, thank you ! |
Contributor
Author
|
I'm happy to help and thanks for the support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧠 Motivation
Map client aborts to 499 and timeouts to 408.
Previously, both were returned as 500, mixing them with genuine server errors. Now, client disconnects are tracked as 499 (Client Closed Request), and request timeouts produce 408 (Request Timeout) to better categorize errors in logs and monitoring tools.