[core] Improve HttpStatus.forStatus by using map lookup
#2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2368 +/- ##
=========================================
Coverage 87.12% 87.13%
Complexity 1320 1320
=========================================
Files 148 148
Lines 4467 4468 +1
Branches 512 512
=========================================
+ Hits 3892 3893 +1
Misses 354 354
Partials 221 221 ☔ View full report in Codecov by Sentry. |
dzikoysk
reviewed
Feb 19, 2025
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
HttpStatus.forStatusimplementation appears to be a brute force search:javalin/javalin/src/main/java/io/javalin/http/HttpStatus.kt
Lines 153 to 154 in 2b63b76
This PR changes the
HttpStatus.forStatusimplementation to use a map lookup, similar toHandlerType.findByName.