Fix virtual threads enabled bug on native images for graalVM #2361
Conversation
…n native images on graalVM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2361 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 148 148
Lines 4498 4492 -6
Branches 513 513
======================================
+ Misses 4498 4492 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @OlavoAcolita ! I see Codecov is complaining a bit, I'm not sure how well tested the existing implementation was 🤔 I will try to have a look before next weekend. @dzikoysk I saw you in the emoji-section of the issue, did you check this out yet? |
| } | ||
|
|
||
| open class ReflectiveVirtualThreadBuilder { | ||
| class VirtualThreadBuilder { |
There was a problem hiding this comment.
You can convert this class into the object class (singleton) and get rid of the companion object at all. It'll make more sense, also considering that we're not creating a new instance of it.
+ should fix coverage
|
@tipsy @OlavoAcolita I've left one comment, despite that I think it's okay |
|
@dzikoysk , we've done as you said. |
|
Hi folks, any update on this? Is there anything else we can assist to get it done? |
|
Sorry, just missed it - things have been busy lately! |
4 participants
Relevant issue: #2192
Fix proposed on issue.
Created a new class (VirtualThreadBuilder) for fixing virtual threads enabled bug on native images for graalVM.