Fix SeekableWriter.kt on file download resumption for non audio/video… #2360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tipsy
reviewed
Jan 14, 2025
tipsy
reviewed
Jan 14, 2025
Rename isAV() extension to isAudioOrVideo() Simplify control flow in "when" statements
Contributor
Author
|
Still need to create new tests for the new control flow of writeSeekableStream |
… status, not 204 add testing for starting download and resuming download
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2360 +/- ##
============================================
+ Coverage 87.09% 87.12% +0.02%
- Complexity 1314 1320 +6
============================================
Files 148 148
Lines 4457 4467 +10
Branches 509 512 +3
============================================
+ Hits 3882 3892 +10
Misses 354 354
Partials 221 221 ☔ View full report in Codecov by Sentry. |
Member
|
Thank you very much ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SeekableWriter.kt on file download resumption for non audio/video files
Relevant issue: #2359
Please note:
2. In the case where you are trying to download a video or audio file directly this error will still occur. Fixing this is pretty non-trivial, as such the implementation for more advanced considerations is not currently implemented in the PR.
Possible solutions to also fix audio/video download resuming as well:
Sec-Fetch-Destheader, which will contain "audio" or "video" when a browser is requesting chunked video/audio segments.Acceptheader, which will contain specific mime types corresponding to the video/audio formats the browser is expecting.