Skip to content

Conversation

@SentryMan
Copy link
Contributor

Now dependabot should create a single PR for the dependency updates. Example dependabot PR: SentryMan/avaje-javalin-api-example#50

Now dependabot should create a single PR for the dependency updates. Example dependabot PR: SentryMan/avaje-javalin-api-example#50
@codecov
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (3afb5b3) to head (e1c4854).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2322   +/-   ##
=========================================
  Coverage     86.30%   86.30%           
  Complexity     1311     1311           
=========================================
  Files           148      148           
  Lines          4044     4044           
  Branches        508      508           
=========================================
  Hits           3490     3490           
  Misses          333      333           
  Partials        221      221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tipsy
Copy link
Member

tipsy commented Sep 2, 2024

@SentryMan I believe we had this, but it didn't work too well, so we reverted back to single commits once per month. Or is this something else?

@SentryMan
Copy link
Contributor Author

Can you expand on that?

@tipsy
Copy link
Member

tipsy commented Sep 2, 2024

#2202
b87db25

Appears to be the same setup that we had.

I can't find the actual issues/PRs now, but basically dependabot would ignore all chat commands to skip versions or rebuild, which made it impossible to merge any of the PRs. I got so frustrated that I reverted back to having individual commits.

@SentryMan
Copy link
Contributor Author

I also tried that dependency group for both dev and the other, but this new config worked for me

@tipsy
Copy link
Member

tipsy commented Sep 2, 2024

We'll give a try, thank you🫡

@tipsy tipsy merged commit 4be2f85 into javalin:master Sep 2, 2024
@SentryMan SentryMan deleted the patch-1 branch September 2, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants