Handle invalid urlencoding in bodies #2245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2245 +/- ##
============================================
+ Coverage 86.31% 86.39% +0.07%
- Complexity 1297 1302 +5
============================================
Files 148 148
Lines 4042 4028 -14
Branches 506 504 -2
============================================
- Hits 3489 3480 -9
+ Misses 334 331 -3
+ Partials 219 217 -2 ☔ View full report in Codecov by Sentry. |
Bodies may exist but not contain valid form params for some requests, and we should handle trying to read params from those requests gracefully
maths22
force-pushed
the
careful-form-params
branch
from
209e358 to
1a8a9c0
Compare
maths22
changed the title
Member
|
Thanks @maths22 ! |
norrs
pushed a commit
to norrs/javalin
that referenced
this pull request
May 16, 2024
Bodies may exist but not contain valid form params for some requests, and we should handle trying to read params from those requests gracefully
norrs
added a commit
to norrs/javalin
that referenced
this pull request
May 16, 2024
Bodies may exist but not contain valid form params for some requests, and we should handle trying to read params from those requests gracefully. "backport" of javalin#2245 for javalin 4x.
norrs
added a commit
to norrs/javalin
that referenced
this pull request
May 16, 2024
Bodies may exist but not contain valid form params for some requests, and we should handle trying to read params from those requests gracefully. "backport" of javalin#2245 for javalin 4x.
norrs
pushed a commit
to norrs/javalin
that referenced
this pull request
May 16, 2024
Bodies may exist but not contain valid form params for some requests, and we should handle trying to read params from those requests gracefully Signed-off-by: Roy Sindre Norangshol <[email protected]>
norrs
added a commit
to norrs/javalin
that referenced
this pull request
May 16, 2024
Bodies may exist but not contain valid form params for some requests, and we should handle trying to read params from those requests gracefully. "backport" of javalin#2245 for javalin 3x. Signed-off-by: Roy Sindre Norangshol <[email protected]>
tipsy
pushed a commit
that referenced
this pull request
May 16, 2024
Bodies may exist but not contain valid form params for some requests, and we should handle trying to read params from those requests gracefully Signed-off-by: Roy Sindre Norangshol <[email protected]> Co-authored-by: Jacob Burroughs <[email protected]>
tipsy
pushed a commit
that referenced
this pull request
May 16, 2024
Bodies may exist but not contain valid form params for some requests, and we should handle trying to read params from those requests gracefully. "backport" of #2245 for javalin 4x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bodies may exist but not contain valid form params for some requests,
and we should handle trying to read params from those requests gracefully