[distribution] Revert 64ccbe1 and use JDK11 for snapshots GH-2117 #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Be aware that this build will fail, see: https://github.com/javalin/javalin/actions/runs/7944870197 The compiled templates need jdk17 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2123 +/- ##
=========================================
Coverage 79.28% 79.28%
Complexity 1264 1264
=========================================
Files 148 148
Lines 4040 4040
Branches 504 504
=========================================
Hits 3203 3203
- Misses 606 607 +1
+ Partials 231 230 -1 ☔ View full report in Codecov by Sentry. |
Member
Author
Speaking about the increasing complexity of the core repo lately be like
|
Member
🥲 |
Member
Author
|
I've checked the cause, and it's not even about compiled templates, but simply the fact that JTE 3.x dropped support for older versions of Java at all: So we're basically blocked in this repo by this. 2 solutions:
I guess it's up to @tipsy to choose. |
Member
|
Neither is fun, but downgrading JTE is the least not fun... |
Member
tipsy
added a commit
that referenced
this pull request
Feb 23, 2024
…to 3.3.0 (#2127) * [context] Prevent unintended usage of JDK 21 feature (closes #2117) - Import import kotlin.collections.removeFirst as removeFirstKt - Set <release> instead of <source> and <target> * [tests] Add more ApiBuilder tests * [distribution] Revert 64ccbe1 and use JDK11 for snapshots GH-2117 (#2123) * [deps]: Bump kotlin.version from 1.9.10 to 1.9.22 (#2128) Bumps `kotlin.version` from 1.9.10 to 1.9.22. Updates `org.jetbrains.kotlin:kotlin-stdlib-jdk8` from 1.9.10 to 1.9.22 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.10...v1.9.22) Updates `org.jetbrains.kotlin:kotlin-reflect` from 1.9.10 to 1.9.22 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.10...v1.9.22) Updates `org.jetbrains.kotlin:kotlin-stdlib-common` from 1.9.10 to 1.9.22 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.10...v1.9.22) Updates `org.jetbrains.kotlin:kotlin-stdlib` from 1.9.10 to 1.9.22 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.10...v1.9.22) Updates `org.jetbrains.kotlin:kotlin-maven-plugin` from 1.9.10 to 1.9.22 --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-stdlib-jdk8 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin:kotlin-reflect dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin:kotlin-stdlib-common dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin:kotlin-stdlib dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin:kotlin-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [deps]: Bump org.apache.maven.plugins:maven-resources-plugin (#2129) Bumps [org.apache.maven.plugins:maven-resources-plugin](https://github.com/apache/maven-resources-plugin) from 3.2.0 to 3.3.1. - [Release notes](https://github.com/apache/maven-resources-plugin/releases) - [Commits](apache/maven-resources-plugin@maven-resources-plugin-3.2.0...maven-resources-plugin-3.3.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-resources-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [deps]: Bump org.apache.maven.plugins:maven-source-plugin Bumps [org.apache.maven.plugins:maven-source-plugin](https://github.com/apache/maven-source-plugin) from 3.2.1 to 3.3.0. - [Commits](apache/maven-source-plugin@maven-source-plugin-3.2.1...maven-source-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-source-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: tipsy <[email protected]> Co-authored-by: dzikoysk <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
tipsy
added a commit
that referenced
this pull request
Feb 23, 2024
* [context] Prevent unintended usage of JDK 21 feature (closes #2117) - Import import kotlin.collections.removeFirst as removeFirstKt - Set <release> instead of <source> and <target> * [tests] Add more ApiBuilder tests * [distribution] Revert 64ccbe1 and use JDK11 for snapshots GH-2117 (#2123) * [deps]: Bump org.assertj:assertj-core from 3.25.0 to 3.25.3 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.25.0 to 3.25.3. - [Release notes](https://github.com/assertj/assertj/releases) - [Commits](assertj/assertj@assertj-build-3.25.0...assertj-build-3.25.3) --- updated-dependencies: - dependency-name: org.assertj:assertj-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: tipsy <[email protected]> Co-authored-by: dzikoysk <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts part of the 64ccbe1
Related to #2117