Linux and Macos file opening fix - #7
Closed
prateekmedia wants to merge 6 commits into
Closed
Conversation
Author
|
@javaherisaber can you merge this please? |
Owner
|
@prateekmedia |
Author
|
It may have some merge conflicts as it is not my code, but from my side it is verified to be legitimate and working. |
Owner
|
@prateekmedia |
|
@javaherisaber any updates or is your fork dead? |
Owner
|
@prateekmedia @lexxxel @miDeb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the code from two files to 4 lines and also fixes the error in linux and mac on opening of files with special characters.
More info from on crazecoder#156: