Enhance stability of tests and prepare for inclusion of appveyor#992
Conversation
…n't need to be closed
- use full qualified path if JAVA_HOME is available - ensure embedded JNA native library is used
…hell Controls And Automation
|
@dblock could you please have a look at this setup? I think I got everything tackled - my builds on appveyor run mostly clean, unittests on my development setup still run |
|
Looks good, although in my application, I remove the "_Total" instance from the list, so it doesn't work with the unmodifiable lists you've used so I'm having to change my iteration. I'm curious the reason to include that? |
|
Looks great, I would add some CHANGELOG and consider @dbwiddis' comment above. Good to merge AFAIK @matthiasblaesing. Great work. |
|
Another small issue. When attempting to use PdhEnumObjectItems with an invalid search string, I receive the error -1073738824 = 0xc0000bb8 (The specified object was not found on the system.) However, in the process throwing the Win32Exception with that value, it loses the value and ends up throwing a LastErrorException:
The constructor for Win32Exception with an |
12b866d to
c742e78
Compare
|
@dbwiddis I agree, that the For the modifiable lists: I have mixed feelings here. I like immutable objects, but I see your use case. Please have another look: |
|
Looks good here. |
Running the JNA unittests on the appveyor CI system shows, that implicit assumptions
in the unittests don't hold everywhere. There are:
and so on.
The referenced commits either express the assumptions as junit assumption (causing the
affected tests to be skipped) or fix/improve the behavior.
Closes: #685