Skip to content

Add package versions to OSGi metadata#982

Merged
matthiasblaesing merged 2 commits intojava-native-access:masterfrom
io7m:master
Jul 5, 2018
Merged

Add package versions to OSGi metadata#982
matthiasblaesing merged 2 commits intojava-native-access:masterfrom
io7m:master

Conversation

@io7m
Copy link
Copy Markdown
Contributor

@io7m io7m commented Jul 1, 2018

This adds version declarations to each exported package in the
OSGi metadata. This allows users to specify that they want a
specific version (or range of versions) of JNA in their OSGi
applications/libraries.

Fix #975

@io7m
Add package versions to OSGi metadata
de74d76 
This adds version declarations to each exported package in the
OSGi metadata. This allows users to specify that they want a
specific version (or range of versions) of JNA in their OSGi
applications/libraries.

Fix java-native-access#975
@io7m
Copy link
Copy Markdown
Contributor Author

io7m commented Jul 1, 2018

I haven't touched the platform jar as there's something in there I'm not sure about: It uses Require-Bundle which is considered very bad practice in modern OSGi. I'd have to know if there was some specific reason this is being used before I go modifying the manifest.

@matthiasblaesing
Copy link
Copy Markdown
Member

matthiasblaesing commented Jul 4, 2018

Thank you Mark, in general this would be ok to merge. Please also add an entry to CHANGES.md. Please see the other entries as a template.
In regard to the Require-Bundle problem - JNA and JNA platform are build together and released together so in this case you don't gain much by switching from bundle to package dependencies. For external users it might be worth adding the version to the exported packages of the platform, as the platform might be split in the future.

@io7m
Add package versions to platform jar
177f22d 
This adds package versions to the platform jar in case the bundle is broken up
into separate pieces in the future. In addition, add an entry to CHANGES.md.

Fix java-native-access#975
@io7m
Copy link
Copy Markdown
Contributor Author

io7m commented Jul 5, 2018

I've added the versions to the platform jar, and added an entry to CHANGES.md.

@io7m
Copy link
Copy Markdown
Contributor Author

io7m commented Jul 5, 2018

Not... sure what that build failure is about. I don't think it's related to the changes I made.

@matthiasblaesing
Copy link
Copy Markdown
Member

matthiasblaesing commented Jul 5, 2018

Looks good - thank you for taking care of it.

@matthiasblaesing matthiasblaesing merged commit 31846f3 into java-native-access:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@io7m @matthiasblaesing