Improve hostname functions#872
Merged
matthiasblaesing merged 1 commit intojava-native-access:masterfrom Nov 10, 2017
Merged
Conversation
twall
reviewed
Nov 8, 2017
| int gethostname(char[] name, int len); | ||
| int sethostname(char[] name, int len); | ||
| int gethostname(byte[] name, int len); | ||
| int sethostname(byte[] name, int len); |
twall
reviewed
Nov 8, 2017
| int getdomainname(char[] name, int len); | ||
| int setdomainname(char[] name, int len); | ||
| int getdomainname(byte[] name, int len); | ||
| int setdomainname(byte[] name, int len); |
7ef9429 to
c82b819
Compare
Fix wrong mapping of libc function gethostname, sethostname,
getdomainname and setdomainname. The functions are defined as:
int getdomainname(char *name, size_t len);
int setdomainname(const char *name, size_t len);
int gethostname(char *name, size_t len);
int sethostname(const char *name, size_t len);
and a C char[] maps by default to a byte[] in java.
In addition bind the winsock gethostname function:
com.sun.jna.platform.win32.Winsock2.gethostname(byte[], int)
The sethostname and setdomainname were tested manually,
as changing the hostname is a privileged operation and
is not regularly possible in unittests.
This closes java-native-access#871
c82b819 to
4d980d6
Compare
Member
Author
|
Thanks for the hint Timothy, adjusted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wrong mapping of libc function gethostname, sethostname,
getdomainname and setdomainname. The functions are defined as:
and a C char[] maps by default to a byte[] in java.
In addition bind the winsock gethostname function:
com.sun.jna.platform.win32.Winsock2.gethostname(byte[], int)
This closes #871