Skip to content

Added GetClientRect#702

Merged
matthiasblaesing merged 4 commits intojava-native-access:masterfrom
jonatino:patch-3
Sep 11, 2016
Merged

Added GetClientRect#702
matthiasblaesing merged 4 commits intojava-native-access:masterfrom
jonatino:patch-3

Conversation

@jonatino
Copy link
Copy Markdown
Contributor

@jonatino jonatino commented Sep 11, 2016

Added GetClientRect function to get the size of the Window excluding the borders.

@jonatino
Added GetClientRect
4e39119 
Added GetClientRect function to get the size of the Window excluding the borders.
@matthiasblaesing
Copy link
Copy Markdown
Member

matthiasblaesing commented Sep 11, 2016

This looks good - two things please:

  • Add an entry for the change to CHANGES.md
  • review the the javadoc for GetWindowRect and GetClientRect, for both the return value is described wrong (it is mapped to boolean, the description is copied from MSDN, so it needs adjustment), the RECT param could then also be adapted.

Thank you!

@jonatino
Copy link
Copy Markdown
Contributor Author

jonatino commented Sep 11, 2016

@matthiasblaesing done.

@matthiasblaesing matthiasblaesing merged commit 84cc379 into java-native-access:master Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonatino @matthiasblaesing