Added EnumResourceTypes and EnumResourceNames to Kernel32#545
Added EnumResourceTypes and EnumResourceNames to Kernel32#545dblock merged 1 commit intojava-native-access:masterfrom mlfreeman2:kernel32-additional-2
Conversation
There was a problem hiding this comment.
This was the mistake. If you don't get the resource into a byte array before calling FreeLibrary() you're doomed.
|
Please try to write at least minimal tests for the individual This PR needs to be rebased against master, too, please. |
|
Added unit tests for the two functions to Kernel32Test.java and rebased against master. |
Added EnumResourceTypes and EnumResourceNames to Kernel32
|
Merged, thank you. |
|
Btw, if anyone is into the whole win32 resources game, a similar project to https://github.com/dblock/resourcelib could probably be useful in Java. |
…e-access#545) Motivation: There is a bug when doing 0RTT and task offloading. Let's disable the test for now until I have time to investigate Modifications: Disable test when offloading is done. Result: Stabilize build
2 participants
This also fixes an embarassing mistake I made in Kernel32Util.getResource().
Like an idiot, I committed it to the branch on my fork, wandered off for a few days, came back, and created the last PR without realizing I'd never run the unit test.