Skip to content

Added com port stuff#510

Merged
dblock merged 1 commit intojava-native-access:masterfrom
MBollig:serialport
Sep 21, 2015
Merged

Added com port stuff#510
dblock merged 1 commit intojava-native-access:masterfrom
MBollig:serialport

Conversation

@MBollig
Copy link
Copy Markdown
Contributor

@MBollig MBollig commented Sep 19, 2015

Added the follwing methods to com.sun.jna.platform.win32.Kernel32:

boolean GetCommState(HANDLE hFile, WinBase.DCB lpDCB);
boolean GetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS lpCommTimeouts);
boolean SetCommState(HANDLE hFile, WinBase.DCB lpDCB);
boolean SetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS lpCommTimeouts);

Added the following structure to com.sun.jna.platform.win32.WinBase:

DCB

Added some new UnitTests

@dblock
Copy link
Copy Markdown
Member

dblock commented Sep 21, 2015

Looks great. Needs a CHANGELOG entry please. And squash your commits.

@MBollig
Copy link
Copy Markdown
Contributor Author

MBollig commented Sep 21, 2015

Hi, added the missing CHANGELOG entries.

Comment thread CHANGES.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a pest, but can we please make these look like the other one-liners? Like

[#452](https://github.com/java-native-access/jna/pull/452): Added Mac OS X System.B library at `com.sun.jna.platform.mac.SystemB`  including support for `sysctl`, `sysctlbyname`, `sysctlnametomib`, `mach_host_self`, `host_page_size`, `host_statistics` and `host_statistics64` - [@dbwiddis](https://github.com/dbwiddis).

@dblock
Copy link
Copy Markdown
Member

dblock commented Sep 21, 2015

Also please squash your commits.

Had to remove a windows style new line to get the buid runnig with cywin

Added com port stuff

Added the follwing methods to com.sun.jna.platform.win32.Kernel32:

boolean GetCommState(HANDLE hFile, WinBase.DCB lpDCB);
boolean GetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS
lpCommTimeouts);
boolean SetCommState(HANDLE hFile, WinBase.DCB lpDCB);
boolean SetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS
lpCommTimeouts);

Added the following structure to com.sun.jna.platform.win32.WinBase:

DCB

Added some new UnitTests

Added new CHANGELOG  entries.

Fixed text

Added com port stuff

Added the follwing methods to com.sun.jna.platform.win32.Kernel32:

boolean GetCommState(HANDLE hFile, WinBase.DCB lpDCB);
boolean GetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS
lpCommTimeouts);
boolean SetCommState(HANDLE hFile, WinBase.DCB lpDCB);
boolean SetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS
lpCommTimeouts);

Added the following structure to com.sun.jna.platform.win32.WinBase:

DCB

Added some new UnitTests
@MBollig
Copy link
Copy Markdown
Contributor Author

MBollig commented Sep 21, 2015

Hi, I fixed the changelog entry and squashed the commits..

dblock added a commit that referenced this pull request Sep 21, 2015
@dblock dblock merged commit 6986251 into java-native-access:master Sep 21, 2015
@dblock
Copy link
Copy Markdown
Member

dblock commented Sep 21, 2015

Merged, thank you.

@MBollig MBollig deleted the serialport branch September 21, 2015 18:56
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
Motivation:

In order to support `native-image`, the project has to provide the
corresponding configuration for reflection, JNI and resources.

Modifications:
- Module `codec-native-quic`: Add profile `native-image-agent` for
generating `native-image` configuration
- New module `testsuite-native-image`: Add profiles
`native-image-quic-server`/`native-image-quic-client` for testing the
`native-image` configuration

Result:
Fixes java-native-access#464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants