Add support for BYTE and CHAR to VARIANT#451
Merged
twall merged 3 commits intojava-native-access:masterfrom Aug 30, 2015
Merged
Add support for BYTE and CHAR to VARIANT#451twall merged 3 commits intojava-native-access:masterfrom
twall merged 3 commits intojava-native-access:masterfrom
Conversation
Add support for VT_UI1 and BYTE constructor. Another thing to consider is that UCHAR type which must match to "unsigned char" for VT_UI1, cant be set. Because bVal is of BYTE class while UCHAR is ancestor of BYTE. Can't assign to bVal UCHAR object instance. In this case it is not possible to make VARIANT(UCHAR value) constructor.
Contributor
|
Corresponding tests? |
These are tests for constructor of variants of CHAR and BYTE
twall
added a commit
that referenced
this pull request
Aug 30, 2015
Add support for BYTE and CHAR to VARIANT
twall
added a commit
that referenced
this pull request
Aug 30, 2015
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
…e-access#451) Motivation:: Previously, the native library would fail to load on older macos versions since the target macos version was not specified correctly. Now, the generated dylib correctly targets macos 10.12. This can be verified with `otool -l codec-native-quic/target/native-build/target/lib/libnetty_quiche_osx_x86_64.jnilib | grep LC_VERSION_MIN_MACOSX -A4` (the output will contain a `version 10.12` line). Modifications: The `-mmacosx-version-min` option is manually added to `cmakeAsmFlags` since cmake doesn't take `MACOSX_DEPLOYMENT_TARGET` into account for asm compilation. The flag is manually added to `extraCflags` and `extraLdflags` since that is the best way I could find to pass the option to hawtjni. Result: This builds and all tests pass on my macbook running macos High Sierra (10.13). I tried running the cross compile profile (though it's not actually cross compiling) and that also build correctly, however I would still suggest testing this on a aarch64 machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propose support for BYTE and CHAR type of VARIANT.