Skip to content

Added to Advapi32: SetThreadToken, GetNamedSecurityInfo, SetNamedSecurityInfo, GetSecurityDescriptorLength, IsValidAcl, IsValidSecurityDescriptor#446

Merged
dblock merged 1 commit intojava-native-access:masterfrom
amarcionek:advapi32-changes-squashed2
May 26, 2015
Merged

Added to Advapi32: SetThreadToken, GetNamedSecurityInfo, SetNamedSecurityInfo, GetSecurityDescriptorLength, IsValidAcl, IsValidSecurityDescriptor#446
dblock merged 1 commit intojava-native-access:masterfrom
amarcionek:advapi32-changes-squashed2

Conversation

@amarcionek
Copy link
Copy Markdown
Contributor

Implementation of the aforementioned functions, as well as a few convenient helpers and wrappers. Also modified the internal private fields of SECURITY_DESCRIPTOR_RELATIVE to make getting the Owner, Group and SACL as easy as the DACL.
Also modified the PSID to get the string representation in an easy way.

@amarcionek
Copy link
Copy Markdown
Contributor Author

Looks like I'll have to change the 443 in changes.md to 446. Is that it?

@dblock
Copy link
Copy Markdown
Member

dblock commented May 26, 2015

Yes, you can do that via an --amend and a git push -f. Change the description of the commit as well to be just what you did, a lot in the old unsquashed history is noise - imagine if you were writing this perfect code from scratch, what would the description be? (probably something close to what's in the CHANGELOG).

 `SetNamedSecurityInfo`, `GetSecurityDescriptorLength`,
 `IsValidSecurityDescriptor`, `IsValidAcl`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@dblock
Copy link
Copy Markdown
Member

dblock commented May 26, 2015

Nice work and thanks for hanging on @amarcionek through my nitpicking! Merging.

dblock added a commit that referenced this pull request May 26, 2015
Added to Advapi32: SetThreadToken, GetNamedSecurityInfo, SetNamedSecurityInfo, GetSecurityDescriptorLength, IsValidAcl, IsValidSecurityDescriptor
@dblock dblock merged commit ca3c2c6 into java-native-access:master May 26, 2015
@amarcionek
Copy link
Copy Markdown
Contributor Author

And thanks for hanging with me through this. I appreciate the guidance. This was my first contribution to an open source project! Been programming closed source C/C++ programs for nearly 15 years. Expect more, by the way, as we have some seriously heavy Windows use cases here.

@amarcionek amarcionek deleted the advapi32-changes-squashed2 branch May 26, 2015 21:33
@dblock
Copy link
Copy Markdown
Member

dblock commented May 26, 2015

👏 👏 👏 👏

mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
…ative-access#446)

Motivation:

We also need to ensure we run all SSL tasks when sending data as otherwise we might stale.

Modifications:

- Correctly run all tasks in all cases
- Reenable usage of executor during tests

Result:

Correctly handling tasks offloading for all cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants