Implementation and tests for window utility methods: Detection of window icon, title and so forth#400
Conversation
title and so forth.
|
It has problems with Umlauts. But they are part of my name... Can this be fixed on the CI? |
There was a problem hiding this comment.
Does HTML in here actually work when JavaDoc is generated?
There was a problem hiding this comment.
You're right! The JavaDoc HTML generation script prints several warnings about that. It seems that I'm not the only one who used HTML content in JavaDoc. I could remove all paragraph/linebreak tags but what should I do with HTML tables? Some documentations have tables?
There was a problem hiding this comment.
Maybe this is a (relatively) recent change to javadoc generation. It used to not be an issue to drop in paragraph and line break tags.
There was a problem hiding this comment.
Dunno. If it renders well in JavaDoc, great. Do note people read those as comments too.
|
You do need to figure out what's up with CI, please, the simplest could be to remove the umlaut from your name if you don't want to deal with the issue. Thanks! |
are mapped to Unicode function invocation, automatically
There was a problem hiding this comment.
This should be loaded with the same options as the other w32 libraries, namely with W32APIOptions.DEFAULT_OPTIONS. That automatically handles A/W suffixes and wide string type mappings.
invocations; Provide correct complete API for Psapi.GetModuleFileNameEx; Test class for Psapi API
|
I hope I have adjusted all mentioned points completely, now. If not then let me know. |
There was a problem hiding this comment.
Since these are mappings we usually write out the names, see above. For example added com.sun.jna.platform.win32.Kernel32Util. getLastErrorMessage. You can also write multiple entries with the same Github link, just so that the changelog is clearer for those who are reading it during the release.
|
I think this is good to merge, just needs a rebase and I would appreciate the small CHANGELOG changes. I want to run these tests on a Windows box before merging, give me a little bit of time. |
icon-extraction-from-hwnd Conflicts: CHANGES.md
|
Is CHANGES file alright, now? |
|
Yes, thanks @PAX523 for the detailed list. |
|
Merged via 95ac06a. |
Motivation: Github does not support windows-2016 anymore Modifications: Switch to windows-2019 Result: Build does not fail anymore on CI
3 participants
I extended some Windows API interfaces in order to provide utility methods that request several information about a HWND instance. Some of these information are: Window icon, window location/size/title, all currently available windows, icon size...