Improved function call performance#353
Merged
twall merged 1 commit intojava-native-access:masterfrom Sep 8, 2015
Merged
Conversation
Member
|
@Boereck You have to rebase with master. Do this: Then, review the diff here. It should look clean. Another, possibly simpler way of doing this is to abandon this branch. |
Author
|
Thanks a lot for your help! I just started my vacation and am away until the 12th of August. I will take care of this as soon as I am back. Currently I am just equipped with my phone. |
Author
|
So the diff here looks good now. You could have a second look now. Thanks! |
Contributor
|
Please re-merge from master, which should fix the CI issue, then this can be merged. |
Boereck
force-pushed
the
faster-method-calls
branch
6 times, most recently
from
3aa6ea4 to
e003913
Compare
Boereck
force-pushed
the
faster-method-calls
branch
from
e003913 to
239e98e
Compare
Author
|
I moved the commit on top of the latest master now. |
Contributor
|
Please resolve the conflict so I can merge this. Sorry for the long delay. |
Boereck
force-pushed
the
faster-method-calls
branch
3 times, most recently
from
8338947 to
49359e6
Compare
Function#invoke. This saves costs for map and reflection lookups.
Boereck
force-pushed
the
faster-method-calls
branch
from
49359e6 to
b6d56e8
Compare
twall
added a commit
that referenced
this pull request
Sep 8, 2015
Improved function call performance
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
Motivation: A new netty release is ou Modifications: Update to latest release Result: Depend on 4.1.70.Final
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, another change for method call performance. Some unnecessary time was spent in Function#invoke(Class returnType, Object[] inArgs, Map options). The method looked up the method object and the parameter types, although this information is already available, when invoking the method from Library$Handler#invoke(Object proxy, Method method, Object[] inArgs). So I refactored both classes a bit so that no unnecessary work is done. In my tests function calls are now measurably faster and produce fewer objects (->less garbage).